I had an E46 M3. Nice cars. Be wary of subframe issues, the power they produced caused them to form tears in the subframe. BMW were repairing them under a goodwill gesture if unmodified and under 10 years old.
As for investment, I doubt it, the are not the same as the E30 which was iconic. The CSL on the other hand is an investment but their prices reflect this.