I'm still working out what to do with my savings. The biggest problem with keeping cash/using savings accounts is that they rarely offer returns larger than inflation (currently around 3%), particularly on large amounts. As such, there is risk with keeping cash as well. Cash ISA accounts are are generally complete waste of time as you rarely get rates >1%, meaning any tax relief is pointless unless you have really large sums.
I'm trying to take advantage of high interest savings accounts (a few 5% ones), but they are severely limited in their contributions and total amount. Typically you cant deposit more than £300 a month and the amount is rarely >£3k. Of course these are generally only offered for 12months and it quickly gets boring moving money around multiple current accounts and savings accounts...!
Which basically leaves the only other option of investments. Two most tax efficient methods are stocks and shares ISA or pensions....Now these are long term solutions. I wouldn't even consider investing for anything shorter than 10-years. The reason pensions are typically so attractive is becuase of the immediate tax relief you gain. This is especially true for high rate tax payers. Now you do pay tax on withdrawal, but remember that 25% is currently tax free, so overall its a tax efficient method of investing.
I make use of high interest savings accounts for short term spending (emergency fund, moving house, eventual car purchase,etc) and the vast majority of my net worth is in property. However when it comes to investing for the long-term I am really tied between investing it into my pension or putting more into my S&S ISA...Being 30, locking my money away till I'm 57 (probably 65 by the time I reach that age..!) doesn't appeal, and I can think of many things I would like to use my money for in say 15/20years time. So I tend to prefer S&S ISA. But as a HRT earner, the tax relief is really appealing too (who doesnt like reducing their tax bill...). It's slightly complicated by the fact that I am currently on a defined benefit scheme (USS), but additional contributions go to an 'investment builder' and I get 1% match from the company too. Free money!
You certainly make a good point about the state of DB pensions, however as mine is university based, I believe it's backed by the government and any benefits accrued so far are 'locked in'. Might be wrong though...
There seems to be extreme pressure to move away from DB and to DC, with rather substantial contributions from the company, however from what I've read the TPS and USS are pretty much as good as it gets pension wise...Will be interesting to see how negations go...